Refactor VariableDefinitionVisitor to resolve memory leak issues#90
Merged
Refactor VariableDefinitionVisitor to resolve memory leak issues#90
Conversation
…marking and remove unused NodeConnectingVisitor service Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the VariableDefinitionVisitor to eliminate memory leaks by removing the dependency on NodeConnectingVisitor and its associated parent node tracking mechanism. The refactor follows the recommendations from the PHPStan blog post on preprocessing AST for custom rules.
Key Changes:
- Replaced parent node traversal pattern with direct node type checking
- Eliminated
NodeConnectingVisitorregistration which was causing memory retention - Introduced recursive
markDefinitionTargets()method to handle nested assignment patterns
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/Rules/CamelCaseVariableName/VariableDefinitionVisitor.php |
Refactored visitor logic to check node types directly instead of using parent references, added recursive marking for complex assignment patterns |
config/extension.neon |
Removed NodeConnectingVisitor service registration to prevent memory leaks |
…ionVisitor Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
VariableDefinitionVisitorto resolve memory leak issues described in https://phpstan.org/blog/preprocessing-ast-for-custom-rules